Sienna-Platform / Sienna-Platform/InfrastructureOptimizationModels.jl

Refactor approximations into abstract types

Open
#114 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
1
Forks
0
Avg merge
8h 51m
Merged PRs (30d)
9

Description

I think we can share some approximation logic by introducing abstract types like SeparableMethod, DisaggregationMethod (if that seems correct for NMDT), SegmentsSomething for sawtooth/SOS2. This would make adding more methods easier, but I don't know if we plan on adding more methods or even keeping all the methods we're using now.

I think we could also make Epigraph more like the other configurations by not having it build a whole series of epigraph cuts, which would allow the separable methods to use it, and then we can introduce a unique helper that builds a series of epigraph cuts, which I think makes more sense because right now Epigraph sorta sits outside the API I feel.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing approximation method implementations and the Epigraph configuration. Compare their shared behavior, including separable methods, NMDT, sawtooth, and SOS2, before deciding whether the proposed abstract types fit. Done would require an agreed API design and a refactor that preserves the current methods and clarifies epigraph-cut construction.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.