Siderite / Siderite/lichessTools
Somehow resolve the inconsistent behavior of tapping the ceval label instead of the ceval toggle
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 92
- Forks
- 20
- Avg merge
- 19h 59m
- Merged PRs (30d)
- 1
Description
Lichess refused to handle it: https://github.com/lichess-org/lila/issues/20096
The code responsible is here: https://github.com/lichess-org/lila/blob/66d2b51af720abe5972c9fb425cccea0c8f66f21/ui/analyse/src/view/controls.ts#L134 and it's being executed when clicking .analyse__controls.
Note that this affects a lot of things, including closing explorer in some situations or hiding ceval but keeping it running, but also all the other buttons with data-act.
Not sure what the solution should be here. I am inclined to just kill the entire thing when data-act == engine-mode and mode == 'ceval', but I am not sure it's not going to break something. One idea is to just make showCeval(false) always stop ceval as well. Needs thinking about, because the current behavior is just atrocious.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ui/analyse/src/view/controls.ts around line 134, where the handler runs for clicks on .analyse__controls. Reproduce tapping the ceval label and toggle, then check the other data-act buttons, explorer closing, and ceval visibility or running state. Done means the interactions behave consistently without breaking those controls.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100