Shopify / Shopify/type_toolkit
Delegate to super `abstract!` implementation, if any
Open
Nobody has claimed this yet.
good first issue
- Dominant language
- Ruby
- Stars
- 3
- Forks
- 5
- Avg merge
- 8d 23h
- Merged PRs (30d)
- 8
Description
Our method name abstract! can conflict with other methods of the same name, e.g. AbstractController::Base.abstract!.
Our implementation should do super if defined?(super)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the implementation of abstract! and inspect how the method is currently defined and tested. Verify the behavior against the AbstractController::Base.abstract! example linked in the issue, and consider the work complete when an available superclass implementation is delegated to without breaking the existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100