Shopify / Shopify/toxiproxy

Toxics are not set when creating a proxy for the first time.

Open
#79 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
12.4k
Forks
510
PR merge metrics
No merged PRs in 30d

Description

When using the Go client as follows, toxics are not added to a proxy.
Given var p []toxiproxy.Proxy with toxics.

proxy := client.NewProxy(&p)
proxy.Create()

This does not properly add the configured toxics from p onto the proxy.

They must be added after the fact using Proxy.SetToxic.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Go client entry points NewProxy and Create, tracing how the configured toxics in p are handled during initial creation. Confirm completion by reproducing the example and verifying that the proxy has its toxics immediately after Create, without calling Proxy.SetToxic.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.