Subnet filtering for toxics
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 12.4k
- Forks
- 510
- PR merge metrics
- No merged PRs in 30d
Description
Would you guys be willing to accept a patch for client ip based filtering for toxics? There would be additional argument subnet( like toxicity) for each toxic which will accept subnet(in CIDR notation) for which this toxic should be applied.
I have it working in my fork and can raise a PR.
commit: https://github.com/Nishant9/toxiproxy/commit/28b10da65e5bb14600d377edab034c3f1b9fd331 (unpolished, haven't added and modified existing tests right now)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the linked fork commit for the existing toxic argument and client-IP filtering approach. Add or update tests for a per-toxic subnet argument in CIDR notation, and confirm that each toxic is applied only to clients in its configured subnet.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100