Shopify / Shopify/toxiproxy

Set bandwidth per application

Open
#190 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
Go
Stars
12.4k
Forks
510
PR merge metrics
No merged PRs in 30d

Description

First off, toxiproxy is awesome.

When setting maximum bandwidth, I expected the rate limiter to be applied on an application basis, but it seems to be limiting rate per connection? With http, this typically means 6x the bandwidth I intended.

I think applying rate limit per app is would be useful, any way to consider that in the future?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a file, test, or entry point. First clarify whether bandwidth should be shared across all connections for an application or proxy and how an application is identified; then inspect the existing rate limiter and add coverage for multiple HTTP connections. Done means the configured maximum is shared as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.