Shopify / Shopify/theme-tools

Section blocks are not validated in `presets` or `default`

Open
#965 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug SEV-3
Dominant language
TypeScript
Stars
234
Forks
92
Avg merge
1d 3h
Merged PRs (30d)
6

Description

ValidBlockTarget also doesn't work for presets if the block defined in the schema is a section block

Image

Originally posted by @aswamy in #751

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace ValidBlockTarget and the validation paths for presets and default, starting with how section blocks are represented in the schema. Compare those paths with ordinary block validation and verify that section blocks defined in the schema are rejected or accepted correctly in both targets.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.