Shopify / Shopify/theme-tools

Warn against missing use of `{{ block.shopify_attributes }}` in blocks with `tag: null`

Open
#867 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
234
Forks
92
Avg merge
1d 3h
Merged PRs (30d)
6

Description

Is your feature request related to a problem? Please describe.

“When ”tag”: null set in block schema, then {{ block.shopify_attributes }} must exist in the markup of the template”

Describe the solution you'd like
For block/*.liquid files, when the {% schema %} contains "tag": null at the top level, then we should report a WARNING severity offence on tag: null

Additional context

https://shopify.dev/docs/storefronts/themes/architecture/blocks/theme-blocks/schema#tag:~:text=of%20the%20block.-,Caution,index%20when%20merchants%20re%2Dorder%20blocks%20without%20leaving%20orphaned%20HTML%20elements.,-Copy

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing validation for block/*.liquid files and how schema-level tag values are reported. Confirm how existing offences assign severity, then verify that tag: null produces a WARNING when block.shopify_attributes is absent; add or run the relevant validation checks if the project provides them.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.