Shopify / Shopify/theme-tools

Invalid completion for `metaobject` type schema settings

Open
#827 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug SEV-3
Dominant language
TypeScript
Stars
234
Forks
92
Avg merge
1d 3h
Merged PRs (30d)
6

Description

Describe the bug
On adding a metaobject schema setting in a section, for example, the default key is suggested.

Image

On trying to upload a setting with this key, the CLI reports that default is not a valid attribute

Image

Source

// sections/test.liquid

{% schema %}
{
  "name": "Test",
  "settings": [
    {
      "type": "metaobject",
      "id": "test",
      "label": "Test",
      "metaobject_type": "test",
      "default": "test"
    }
  ]
}
{% endschema %}

Expected behaviour
default is not suggested as a key for metaobject schema settings

Actual behaviour
default is suggested as a key for metaobject schema settings

Debugging information

  • OS: masOs
  • OS Version: Sequoia 15.3.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the schema completion and CLI validation using the provided sections/test.liquid example. Trace the metaobject schema-setting completion and validation entry points, then verify that default is no longer suggested while valid attributes remain available.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.