Shopify / Shopify/theme-tools

Shopify Liquid formatter doesn't format a HTML in a default Shopify's email template.

Open
#760 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area:prettier-plugin enhancement
Dominant language
TypeScript
Stars
234
Forks
92
Avg merge
1d 3h
Merged PRs (30d)
6

Description

Describe the bug
I copy an email template from notifications - Edit order confirmation, into vs code. Formatting with Shopify liquid does not structure HTML, that I can work easily. In addition HTML formatter brokes the template (HTML language features formatter), so there is no way to make the layout looks readable.

Source
Copy the template from default shopify's customer notification template "Edit Order confirmation" in to VS code, try to format with Shopify Liquid.

Expected behaviour
Html becomes readable, liquid is readable also. Template's UI doesn't lose any elements

Actual behaviour
HTML isn't formatted.
Liquid is readable.
Template doesn't lose elements.

Debugging information

  • OS Mac "Sequoia 15.1.1"
  • Shopify CLI version "3.74.1"
  • Theme Check Version "unknown"
  • Shopify Liquid extension version "3.5.3"

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is identified. Reproduce the problem in VS Code with Shopify's default “Edit Order confirmation” email template, then trace the formatter entry point; done means the HTML and Liquid are readable without losing template elements.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.