Theme check should warn you when you have `presets` and `default`
Open
Nobody has claimed this yet.
area:theme-check
Bug
SEV-4
- Dominant language
- TypeScript
- Stars
- 234
- Forks
- 92
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Describe the bug
If you have a presets and default in your section file's schema, you will see no theme check error, but when you run shopify theme dev, you will see an error saying the error.
Source
Expected behaviour
- Theme check should catch the error in VSCode
- Theme check in CLI should catch the error (i.e. running
shopify theme check)
Actual behaviour
- No errors are shown until you run
shopify theme dev
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the theme check rule or schema validation entry point used by both the VSCode extension and the CLI. Reproduce a section schema containing both presets and default, then add coverage showing that theme check reports the same error before shopify theme dev is run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100