Shopify / Shopify/theme-tools

`TranslationKeyExists` check not detecting translations in section schema

Open
#721 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug SEV-3
Dominant language
TypeScript
Stars
234
Forks
92
Avg merge
1d 3h
Merged PRs (30d)
6

Description

Describe the bug
When using the locales object in a section schema, Theme Check incorrectly flags them as missing

Image

Source

// section/test-section.liquid

<p>{{ 'sections.test-section.title' | t }}</p>
<p>{{ 'sections.test-section.description.desktop' | t }}</p>
<p>{{ 'sections.test-section.description.mobile' | t }}</p>

{% schema %}
{
  "name": "Section",
  "locales": {
    "en": {
      "title": "Title",
      "description": {
        "desktop": "Lorem ipsum dolor sit amet consectetur, adipisicing elit.",
        "mobile": "Lorem ipsum dolor sit amet"
      }
    }
  }
}
{% endschema %}

Expected behaviour
No errors

Actual behaviour
The first three lines all have TranslationKeyExists errors

Debugging information

  • OS: Mac
  • OS Version: Sequoia 15.2
  • Theme Check Version: 3.73.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the TranslationKeyExists check for the section/test-section.liquid example and how it reads the schema's locales object. Verify the nested title and description.desktop/mobile keys against the translation references, then confirm the expected behavior produces no errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
internationalization, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.