Shopify / Shopify/theme-tools

Missing completions for section locales

Open
#720 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement SEV-3
Dominant language
TypeScript
Stars
234
Forks
92
Avg merge
1d 3h
Merged PRs (30d)
6

Description

Describe the bug
When using the locales object in a section schema, those locales aren't surfaced as completion suggestions

Image

Source

// section/test-section.liquid

{{ 'sections.test-' }}

{% schema %}
{
  "name": "Section",
  "locales": {
    "en": {
      "title": "Title"
    }
  }
}
{% endschema %}

Expected behaviour
Whilst typing 'sections.test-' in the tag at the top, 'sections.test-section.title' | t' should be suggested, like with locales defined in locales/*.json

Actual behaviour
Nothing is suggested

Debugging information

  • OS: Mac
  • OS Version: Sequoia 15.2
  • Theme Check Version: 3.73.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce completion in section/test-section.liquid using the provided schema, then compare it with locale entries from locales/*.json. Trace how the editor discovers translation keys and ensure section-schema locales produce the expected sections.test-section.title suggestion; verify the original example no longer returns no suggestions.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.