Section rename handling in config/settings_data.json
Open
Nobody has claimed this yet.
good first issue
- Dominant language
- TypeScript
- Stars
- 234
- Forks
- 92
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Describe the bug
Looks like there's an undocumented behaviour of config/settings_data.json we'd need to think about:
https://github.com/Shopify/dawn/blob/main/config/settings_data.json#L173-L185
- Section type should be renamed
- Does that thing accept blocks? Do we rename blocks in there too?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect config/settings_data.json at lines 173-185 and trace how theme-tools currently handles section type renames. Determine whether blocks are accepted there and whether their names also need renaming; done means the expected behavior is decided and reflected in the relevant handling or documentation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100