Followup functionality for `DeprecatedTags`
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- TypeScript
- Stars
- 234
- Forks
- 92
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
This feature is related to this PR. As per comments left here we need to add some bonus functionality for our ConvertIncludeToRender check included under DeprecatedTags. This bonus functionality includes the following requirements:
- Collect list of implicit variables used by target file (include)
- Change include to render with the implicit variables passed as arguments to the render tag
Some additional notes to help add these bonus requirements is:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #50 and the ConvertIncludeToRender check under DeprecatedTags, then read the linked discussion in theme-check-js issue #47 for context on implicit variables. Done means collecting the target include's implicit variables and passing them as arguments when converting the include to a render tag.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100