Shopify / Shopify/theme-tools

prettier.config.js doesn't load in extension

Open
#619 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug
Dominant language
TypeScript
Stars
234
Forks
92
Avg merge
1d 3h
Merged PRs (30d)
6

Description

Describe the bug
When a user has a ESM prettier config (prettier.config.js), the formatter doesn't do anything and logs the error to the "Output > Window" logs. Nothing happens and there's no feedback to the user.

Expected behaviour
We support modern prettier configs, or we gracefully handle config errors by using default configuration/error message to user.

Actual behaviour
Nothing happens and the logs are in a different log window. It's confusing as hell.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with an ESM prettier.config.js and trace the extension's formatter configuration loading, using the Output > Window logs to identify the failure. Done means the formatter applies the modern config or clearly reports the configuration error while retaining a usable default behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.