Follow up on 599
Open
Nobody has claimed this yet.
tech debt
- Dominant language
- TypeScript
- Stars
- 234
- Forks
- 92
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
#599 follow-ups
Mostly deal with theme app extensions with the same level of niceness. I've kind of ignored them in order to ship 599 really quickly before burst.
### Tasks
- [ ] Translate Theme App Extension schemas into TS interfaces
- [ ] Inject `getAppBlockSchema('')` from language server/runChecks
- [ ] Inject `getAppBlockSchema('')` in theme-check-node
- [ ] https://github.com/Shopify/theme-tools/issues/601
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #599 and the Theme App Extension schema handling referenced here. Then inspect the language server/runChecks entry point and theme-check-node to understand where getAppBlockSchema('') should be injected. Done means the schemas are represented as TypeScript interfaces, both injection paths work, and issue #601 is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100