Require `other` for pluralized entries in translation files
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 234
- Forks
- 92
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
As of writing, pluralization keys have no requirements – as long as they're present, the linter won't complete.
theme-lint has a rule to enforce other in the default locale: https://github.com/Shopify/theme-lint/blob/239d40432ad20e50f1e7e90bd618e58cdfe09690/linters/i18n.js#L199-L201 -- maybe we can do something similar in MatchingTranslations, but make it possible to opt-out with a parameter on the check?
See: https://github.com/Shopify/theme-check/pull/49#discussion_r536366580
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading MatchingTranslations and the referenced theme-lint i18n rule to compare how pluralized entries are checked. Identify the existing check’s call sites and verification coverage, then define the opt-out parameter and confirm that entries require other by default while opted-out checks retain their existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- localization
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100