[Intelligent code completion] Support collection retrieved via its name
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 234
- Forks
- 92
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Created by
https://github.com/Shopify/theme-liquid-docs/issues/18
Describe the bug
Intelligent Code Completion does not support collection retrieved via its name.
Therefore, collections.first.products is supported, but collections['sale-potions'].products isn't.
Expected
In the example …
{% for x in collections['sale-potions'].products %}
{{- x.█
… x should be treated as a product, so that suggestions for product (available, collections, compare_at_price, …) are displayed at the cursor's position.
Actual
x seems to be treated as a collection, so that suggestions for collection are displayed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the intelligent code-completion entry point that resolves collection access, then trace how bracketed collection names are handled in the provided Liquid example. Done means collections['sale-potions'].products infers x as a product and shows product suggestions at the cursor.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- developer-experience, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100