JSON formatting issues with the Shopify Github Integration
Open
Nobody has claimed this yet.
area:prettier-plugin
Bug
Severity: 3
- Dominant language
- TypeScript
- Stars
- 234
- Forks
- 92
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Describe the bug
When using the shopify github integration, I am getting back file urls as an escaped string. Then when running prettier, it is removing the \ from the url.
Unformatted source
shopify:\/\/shop_images\/Logo_2bb829935e.webp
Expected output
shopify:\/\/shop_images\/Logo_2bb829935e.webp
Actual output
shopify://shop_images/Logo_2bb829935e.webp
Debugging information
- OS [e.g. Windows, Mac, Linux]
- Version [e.g. 0.1.0]
Additional context
Here is my prettier config:
//.prettierrc.json
{
"printWidth": 120,
"singleQuote": true,
"overrides": [
{
"files": "*.liquid",
"options": {
"singleQuote": false
}
}
],
"plugins": ["@shopify/prettier-plugin-liquid", "prettier-plugin-tailwindcss"]
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported behavior with the .prettierrc.json configuration, the @shopify/prettier-plugin-liquid and prettier-plugin-tailwindcss plugins, and a minimal *.liquid input containing the escaped Shopify URL. Compare the formatted result with the expected output; done means the backslashes in that URL remain intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100