Formatter ignores liquid quotes inside HTML attributes
Open
Nobody has claimed this yet.
Bug
Severity: 4
- Dominant language
- TypeScript
- Stars
- 234
- Forks
- 92
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Describe the bug
Formatter ignores liquid quotes inside HTML attributes with liquidSingleQuote enabled.
Source
<div class="{{ "test" }}"></div>
Expected behaviour
<div class="{{ 'test' }}"></div>
Actual behaviour
<div class="{{ "test" }}"></div>
Debugging information
@shopify/prettier-plugin-liquid@1.4.1
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the case with @shopify/prettier-plugin-liquid@1.4.1 using the provided Liquid source and liquidSingleQuote option. Trace how Liquid expressions embedded in HTML attributes are formatted; done when the inner "test" is converted to 'test' without changing the surrounding attribute.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100