Shopify / Shopify/theme-tools

inserts extra ">" if: <label>text</label><textarea></textarea>

Open
#1,288 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
234
Forks
92
Avg merge
1d 3h
Merged PRs (30d)
6

Description

Describe the bug
When an inline element (e.g. <label>, <span>) directly hugs a following <textarea> (no whitespace between them), the printer inserts a stray literal > character between the two elements. This changes the rendered page: the stray > becomes visible text in the DOM.

Source

<div>
  <label for="x">Name</label><textarea id="x" rows="4"></textarea>
</div>

Expected behaviour
The extra > is not inserted...

Actual behaviour

<div><label for="x">Name</label>><textarea id="x" rows="4"></textarea></div>

Debugging information
OS: macOS
OS Version: Darwin 25.6.0
@shopify/prettier-plugin-liquid: 1.11.0
prettier: 3.9.6
Not using Theme Check; invoking prettier CLI directly (prettier --plugin=@shopify/prettier-plugin-liquid). Reproduces at printWidth 80, 200, and 9999, singleAttributePerLine: false.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the formatter output with the provided label and textarea source using the prettier CLI and the @shopify/prettier-plugin-liquid plugin, checking the listed printWidth settings. Trace the formatting path for adjacent inline elements and textarea elements; done means no literal > appears between them and the output matches the expected HTML.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.