Liquid in HTML comment is ignored for UnknownObject purposes
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 234
- Forks
- 92
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Describe the bug
https://community.shopify.dev/t/shopify-theme-check-ignores-liquid-within-html-comments/28183
Source
<!-- {% assign foo = 10 %} -->
{{ foo }}
Expected behaviour
No issue
Actual behaviour
Apparently this triggers a theme check UnknownObject error
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No implementation file, test, or entry point is named. Reproduce the reported Liquid example in the issue and trace the UnknownObject check for variables inside HTML comments; done means the snippet no longer reports an UnknownObject issue while ordinary unknown objects remain checked.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100