Shopify / Shopify/theme-tools

Standalone prettier plugin build imports "prettier" instead of "prettier/standalone"

Open
#1,098 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
234
Forks
92
Avg merge
1d 3h
Merged PRs (30d)
6

Description

Describe the bug
The standalone build of the prettier plugin includes require("prettier") instead of require("prettier/standalone"), meaning the build ends up trying to include Node modules (e.g. "module, "url" and "path")

Source
import prettierPluginLiquid from "prettier-plugin-liquid/standalone"

Expected behaviour
Should work in the browser

Actual behaviour
Image

Debugging information

  • OS MacOS
  • OS Version Tahoe 26.2

Additional context
Import can be seen in the first line here: https://unpkg.com/@shopify/prettier-plugin-liquid@1.10.0/standalone.js

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the standalone entry referenced by import prettierPluginLiquid from "prettier-plugin-liquid/standalone" and compare it with the generated standalone.js shown at unpkg. Verify the browser build no longer emits require("prettier") or Node-module imports, and confirm the standalone plugin works in a browser.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.