Shopify / Shopify/theme-tools

[Bug]: Theme check in CLI does not report cross-file LiquidDoc errors

Open
#1,022 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Severity: 3 Windows
Dominant language
TypeScript
Stars
234
Forks
92
Avg merge
1d 3h
Merged PRs (30d)
6

Description

Please confirm that you have:
  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.
In which of these areas are you experiencing a problem?

Theme

Expected behavior
  • When you run shopify theme check I want to see all the theme-checks that show up in VSCode
Actual behavior
  • LiquidDoc error does show up when its within the same file
  • Cross-file LiquidDoc errors (like when one is referenced via render or content_for tag do not show up)

NOTE: This only happened on my Windows, but it works on my Mac

Image
Verbose output
  • not needed
Reproduction steps
  1. Create a snippet with LiquidDoc with at least 1 required param
  2. Render that snippet, without passing in the required args
  3. See the error in VSCode
  4. Run shopify theme check and notice it does not appear in the logs
Operating System

Windows 11

Shopify CLI version (shopify --version)

3.83.1

Shell

No response

Node version (run node -v if you're not sure)

No response

What language and version are you using in your application?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reproduction steps and the shopify theme check entry point, using a snippet with a required LiquidDoc parameter and a cross-file render or content_for reference. Compare the CLI output with VSCode on Windows 11 and macOS; done means the CLI reports the same cross-file LiquidDoc error as VSCode.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.