[Bug]: Theme check in CLI does not report cross-file LiquidDoc errors
Open
Nobody has claimed this yet.
Severity: 3
Windows
- Dominant language
- TypeScript
- Stars
- 234
- Forks
- 92
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Please confirm that you have:
- Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
- Reproduced the issue in the latest CLI version.
In which of these areas are you experiencing a problem?
Theme
Expected behavior
- When you run
shopify theme checkI want to see all the theme-checks that show up in VSCode
Actual behavior
- LiquidDoc error does show up when its within the same file
- Cross-file LiquidDoc errors (like when one is referenced via
renderorcontent_fortag do not show up)
NOTE: This only happened on my Windows, but it works on my Mac
Verbose output
- not needed
Reproduction steps
- Create a snippet with LiquidDoc with at least 1 required param
- Render that snippet, without passing in the required args
- See the error in VSCode
- Run
shopify theme checkand notice it does not appear in the logs
Operating System
Windows 11
Shopify CLI version (shopify --version)
3.83.1
Shell
No response
Node version (run node -v if you're not sure)
No response
What language and version are you using in your application?
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproduction steps and the shopify theme check entry point, using a snippet with a required LiquidDoc parameter and a cross-file render or content_for reference. Compare the CLI output with VSCode on Windows 11 and macOS; done means the CLI reports the same cross-file LiquidDoc error as VSCode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cli, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100