Shopify / Shopify/tapioca

DSL test helpers should require all that is needed for running tests

Open
#922 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
873
Forks
164
Avg merge
4d 27m
Merged PRs (30d)
9

Description

When using our DSL compiler test helper by it self, executing the test fails because certain constants are not defined.

The following list of requires makes tests run properly, but might include extraneous requires or be missing other important ones. The immediate two issues that appeared were: the DSL compiler class not being defined and runtime not being defined.

require "tapioca/runtime/reflection"
require "tapioca/runtime/trackers"
require "tapioca/runtime/dynamic_mixin_compiler"
require "tapioca/runtime/loader"
require "tapioca/dsl/compiler"
require "tapioca/helpers/test/dsl_compiler"

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the requires listed in the issue and the tapioca/helpers/test/dsl_compiler helper, then run the DSL compiler tests in isolation to reproduce the missing constants. Check which dependencies are actually needed and verify that the helper's standalone tests pass with a minimal complete require set.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.