Shopify / Shopify/tapioca

Support `ActionDispatch::SystemTestCase` within UrlHelpers compiler

Open
#629 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Ruby
Stars
873
Forks
164
Avg merge
4d 27m
Merged PRs (30d)
9

Description

ActionDispatch::SystemTestCase uses method_missing to utilize UrlHelpers https://github.com/rails/rails/blob/19e4b7a609e79b6be80b5355e4ff3882ad59f09e/actionpack/lib/action_dispatch/system_test_case.rb#L182.

We can add a special case within UrlHelpers compiler to mixin the generated modules:

class ActionDispatch::SystemTestCase
  include GeneratedPathHelpersModule
  include GeneratedUrlHelpersModule
end

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the UrlHelpers compiler and the referenced actionpack/lib/action_dispatch/system_test_case.rb implementation around line 182. Add the special handling for ActionDispatch::SystemTestCase so generated path and URL helper modules are included, then verify the generated RBI output covers those helpers.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.