Shopify / Shopify/tapioca

Test PostgreSQL ActiveRecord adapter types

Open
#2,149 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

gh-actions help-wanted
Dominant language
Ruby
Stars
873
Forks
164
Avg merge
4d 27m
Merged PRs (30d)
9

Description

Postgres support in Tapioca for ActiveRecordColumns DSL compiler has been slowly increasing https://github.com/search?q=repo%3AShopify%2Ftapioca%20postgresql&type=code. As a result we have untested code paths since we only run an in memory SQLite database during tests. We should have CI setup where we can observe column types under the ActiveRecord::ConnectionAdapters::PostgreSQL namespace.

Questions:

  • Do we need to run postgres to be able to test the ActiveRecord adapter? (It'd be great if we didn't)
  • If we do run postgres, do we need a service container with a postgres image (ex) or is it already available in our image and we can just activate it?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing ActiveRecordColumns tests and CI setup, which currently use an in-memory SQLite database. Determine whether PostgreSQL must run in CI and whether a service container or existing image support is appropriate. Done means PostgreSQL adapter column types are exercised in CI.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql, rails, ruby
Domain
ci-cd, databases, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.