Shopify / Shopify/tapioca

Investigate support of `GraphQL::Schema::NonNull`

Open
#1,697 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
873
Forks
164
Avg merge
4d 27m
Merged PRs (30d)
9

Description

#1571 was added to handle NonNull types, but in #1695 we found that the type_for helper's NonNull branch is calling a non existing method, which indicates that the branch was never entered. Therefore, we should investigate whether the intended NonNull type support was already covered by other things, or we need to implement it differently.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading #1571 and the discussion in #1695, then inspect the type_for helper and its NonNull branch. Determine whether existing support already covers GraphQL::Schema::NonNull or whether a different implementation is needed; the issue is done when that behavior is established and the appropriate support path is clear.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, ruby
Domain
api, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.