Shopify / Shopify/tapioca

Should we support `ActiveRecord::Store`?

Open
#1,217 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement feature help-wanted
Dominant language
Ruby
Stars
873
Forks
164
Avg merge
4d 27m
Merged PRs (30d)
9

Description

Our application uses ActiveRecord::Store, but Tapioca does not support it, so we had to write a shim. I began investigating adding it, but while looking for where to implement it I discovered we support ActiveRecord::TypedStore.

Before I go any further, I'd like to establish the project's stance:

  • Are we open to supporting ActiveRecord::Store, or
  • do we recommend consumers use ActiveRecord::TypedStore instead?

I should note that I only found out about TypedStore because I looked into adding support for Store. If we prefer one over the other, we could, for example, log a message if we detect the host app uses ActiveRecord::Store advising they switch.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No implementation file or test is named. Start by reviewing how the existing ActiveRecord::TypedStore support is implemented and compare it with the requested ActiveRecord::Store support; done means recording a clear project decision and corresponding guidance for consumers.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.