Shopify / Shopify/shopify_python_api

prerequisite_customer_ids array is ignored

Open
#233 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
Python
Stars
1.4k
Forks
388
Avg merge
5h 39m
Merged PRs (30d)
1

Description

I'm using the shopify python api and cannot add prerequisite_customer_ids array to a price rule.

  1. I can add a PriceRule, just fine.

  2. I can add prerequisite_saved_search_ids, just fine.

Is there no support for prerequisite_customer_ids yet in the python API (yet)?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the PriceRule handling for prerequisite_saved_search_ids and compare it with the requested prerequisite_customer_ids field. Check how PriceRule attributes are serialized for creation, then verify that the customer ID array is accepted and sent correctly. Done means a PriceRule can be created with prerequisite_customer_ids, with coverage added if the repository has a relevant test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.