Remove `private_shop` configuration from Context generating a new app
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.9k
- Forks
- 739
- Avg merge
- 21h 2m
- Merged PRs (30d)
- 1
Description
Overview/summary
Geneating a new app with shopify_app, we are copying the private_shop configuration in the setup.
Is this still needed? I couldn't find any documentation on in which cases this option makes sense to be used. If we can remove it, I can make a PR for that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lib/generators/shopify_app/install/templates/shopify_app.rb.tt, especially the setup line linked in the issue, and search the repository for other uses of private_shop. Confirm whether the configuration is still required; if not, remove it from generated app setup and verify the generator output no longer includes it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100