Shopify / Shopify/shopify_app

redirect.html.erb fails silently if JavaScript is disabled

Open
#1,798 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
1.9k
Forks
739
Avg merge
21h 2m
Merged PRs (30d)
1

Description

Issue summary

A user has JavaScript disabled and tries to install an app by going to /login and entering their shop name. After submitting the /login page they just get a blank page and nothing happens.

  • shopify_api version: 13.1.0
  • shopify_app version: 21.6.0
  • Ruby version: 3.2.1
  • Operating system: All

Expected behavior

The user should see an indication that they need to have JavaScript enabled.

Actual behavior

They get a blank screen.

Steps to reproduce the problem

  1. Disable JavaScript
  2. Go to the /login page of an app
  3. Enter a *.myshopify.com domain
  4. Submit the form
  5. See a blank page
  6. View source
  7. See that you've been served the redirect.hml.erb page, which contains only an empty div and a link to a redirect.js script.

Blank page:

CleanShot 2024-02-28 at 10 35 43

View source:

CleanShot 2024-02-28 at 10 35 52

Problem file:

https://github.com/Shopify/shopify_app/blob/2a75c07e98ca171aca53ca5af1d9a2fe29489b20/app/views/shopify_app/shared/redirect.html.erb#L10-L22

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with app/views/shopify_app/shared/redirect.html.erb and reproduce the /login flow with JavaScript disabled. Check the rendered source and ensure the page gives users a visible indication that JavaScript must be enabled instead of showing a blank screen.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, rails, ruby
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.