redirect.html.erb fails silently if JavaScript is disabled
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.9k
- Forks
- 739
- Avg merge
- 21h 2m
- Merged PRs (30d)
- 1
Description
Issue summary
A user has JavaScript disabled and tries to install an app by going to /login and entering their shop name. After submitting the /login page they just get a blank page and nothing happens.
shopify_apiversion: 13.1.0shopify_appversion: 21.6.0- Ruby version: 3.2.1
- Operating system: All
Expected behavior
The user should see an indication that they need to have JavaScript enabled.
Actual behavior
They get a blank screen.
Steps to reproduce the problem
- Disable JavaScript
- Go to the
/loginpage of an app - Enter a
*.myshopify.comdomain - Submit the form
- See a blank page
- View source
- See that you've been served the
redirect.hml.erbpage, which contains only an empty div and a link to aredirect.jsscript.
Blank page:
View source:
Problem file:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with app/views/shopify_app/shared/redirect.html.erb and reproduce the /login flow with JavaScript disabled. Check the rendered source and ensure the page gives users a visible indication that JavaScript must be enabled instead of showing a blank screen.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, rails, ruby
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100