Is all of rails actually required?
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.9k
- Forks
- 739
- Avg merge
- 21h 2m
- Merged PRs (30d)
- 1
Description
Overview/summary
While I was looking to trim my Docker image down by reducing dependencies around unused parts of Rails I notice that shopify_app depends on all of rails, not just key parts.
Is this an accurate requirement or more of a connivence?
For example: I assume you don't need actionmailer, actionmailbox, actioncable as i cant see any of them used in the code base
NB the rails gem itself is just a collection of dependencies so we can clearly see what we need from there 🤷
I can see this issue too, but Im not sure if the rational is actually valid 🤷
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the dependency declaration in shopify_app.gemspec at the linked line, then compare it with the Rails v7.0.3 rails.gemspec and inspect the codebase for the listed Rails components. Review issue #604 for prior rationale; done means determining and documenting which dependencies are actually required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- backend, tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100