Shopify / Shopify/shopify-app-template-php

Frontend directory is pointing to an outdated version of the frontend template repository

Open
#446 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
340
Forks
108
PR merge metrics
No merged PRs in 30d

Description

Issue summary

When trying to use some components from Polaris I got an error

Uncaught SyntaxError: The requested module '/node_modules/.vite/deps/@shopify_polaris.js?v=4fb69a76' does not provide an export named 'Text'

After looking I noticed some of the frontend node dependencies are outdated.

"dependencies": {
    "@shopify/app-bridge": "^3.1.0", // 3.7.7 available
    "@shopify/app-bridge-react": "^3.1.0", // 3.7.7 available
    "@shopify/app-bridge-utils": "^3.1.0", // 3.7.7 available
    "@shopify/polaris": "^9.11.0", // 10.49.1 available
    "@vitejs/plugin-react": "1.2.0",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "react-query": "^3.34.19",
    "react-router-dom": "^6.3.0",
    "vite": "^2.8.6" // 4.3.9 available
  },

I realized the frontend directory is pointing to an outdated version of the frontend template repository frontend @ f720a83

Updating the frontend directory and installing the dependencies again fix the issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the frontend directory and compare it with the linked shopify-frontend-template-react commit. Update the directory and reinstall its dependencies, then verify that the Polaris Text export no longer produces the reported Vite error.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, vite
Domain
build-system, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.