Shopify / Shopify/shopify-app-template-node

missing script "build"

Open
#1,311 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Waiting for Response
Dominant language
JavaScript
Stars
1k
Forks
434
PR merge metrics
No merged PRs in 30d

Description

hello all!

i just downlaoded this template to work on a node project for shopify but when im trying to build the docker image to deploy this project into our services on AWS, im getting the error that there is no script for the build command inside my package.
and after checking the package inside the front there is no build command, so why the dockerfile uses that command on the line: RUN cd frontend && npm install && npm run build?

  • @shopify/shopify-app-express version: 2.1.3
  • Node version: 18
  • Operating system: windows 11
// Paste any relevant logs here
1.907 npm ERR! Missing script: "build"
1.907 npm ERR!
1.908 npm ERR! To see a list of scripts, run:
1.908 npm ERR!   npm run
1.910
1.910 npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2023-12-13T20_37_53_347Z-debug-0.log
------
Dockerfile:9
--------------------
   7 |     COPY web .
   8 |     RUN npm install
   9 | >>> RUN cd frontend && npm install && npm run build
  10 |     CMD ["npm", "run", "serve"]
  11 |
--------------------
ERROR: failed to solve: process "/bin/sh -c cd frontend && npm install && npm run build" did not complete successfully: exit code: 1

Expected behavior

build the docker image

Actual behavior

error on building image

Steps to reproduce the problem

  1. run docker build

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Dockerfile line that runs cd frontend && npm install && npm run build, then inspect the frontend package scripts and the reported npm error. Confirm the intended frontend build command and verify that docker build completes successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, docker, javascript, nodejs
Domain
build-system, devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.