Shopify / Shopify/shopify-app-template-node

blocker bug - App template is broken. It not pass review process. Not tested?

Open
#1,154 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1k
Forks
434
PR merge metrics
No merged PRs in 30d

Description

Issue summary

I build app from recommended template, but it fails review, and the message is to follow OAuth documentation. But the documentation says I should not do anything when using recommended app template. Shopify devs, have you tested it? You are almost lost serious client for which we trying to publish app longer, then our company was developing it.
As you can easily see there are a lot of open issues related to auth.

Expected behavior

App created using template should not fail review process for reasons, that are implemented and handled by template.

Actual behavior

We receive rejections with wrong OAuth behaviour

Tip: include an error message (in a <details></details> tag) if your issue is related to an error

Steps to reproduce the problem

      1. Create app using template, enable one time billing, try to pass review submitting to app store.

Reduced test case

The best way to get your bug fixed is to provide a reduced test case.

Specifications

  • Browser: Chrome latest
  • Device: MacBook Pro
  • Operating System: MacOS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported flow by creating an app from the recommended template, enabling one-time billing, and submitting it to the App Store review process. Compare the rejection's OAuth requirements with the template's OAuth documentation; done means the template-created app no longer receives the reported OAuth rejection.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
authentication, payments
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.