Shopify / Shopify/shopify-app-template-node
Payment recursive
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1k
- Forks
- 434
- PR merge metrics
- No merged PRs in 30d
Description
I have a problem with recursive. Support rejected the app.
Video:
https://shopify.click/22-09-58372-51768.webm
I think this recursive between auth.js and verify-request.js.
We check the payment several times and because of this we get a recursion
I found the problem in this place:
https://github.com/Shopify/shopify-app-template-node/blob/0a987b4d3de8c62540b2f4aa6e97ad0261a16e3c/web/middleware/auth.js#L40-L49
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with web/middleware/auth.js lines 40-49 and web/middleware/verify-request.js lines 37-45, then use the supplied video and error image to trace the repeated payment check. Done means the reported payment flow no longer recurses between authentication and request verification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authentication, payments
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100