Shopify / Shopify/shopify-app-js
BillingConfigItem for v3 still requires future flags to use lineItemBilling
Open
Nobody has claimed this yet.
Stale
- Dominant language
- TypeScript
- Stars
- 540
- Forks
- 225
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 6
Description
This is caused by the code defaulting to the BillingConfigLegacyItem if the flag isn't present, but it isn't an option in v3 and is a requirement.
This is causing my jest testing to go haywire because the types don't match. Is it worth removing the Future for BillingConfigItem in v3?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test path is named. Start by tracing the v3 definitions of BillingConfigItem and BillingConfigLegacyItem, especially the lineItemBilling and Future flag requirements; verify the Jest type failures, and consider the issue done when v3 no longer requires unsupported future flags and the types match.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- payments
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100