Shopify / Shopify/shopify-api-ruby

Add proxy support for HTTP requests

Open
#1,375 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
1.1k
Forks
484
PR merge metrics
No merged PRs in 30d

Description

Overview

For security reasons, some applications are not allowed direct access to the internet, so a proxy server should be used, but ShopifyAPI does not allow passing proxy server options, despite HTTParty itself allowing it.

As an override global setting HTTParty::Basement.http_proxy('proxy.server', 8000, nil, nil) can be used, but it may break other usage of HTTParty where it uses for internal communication.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how ShopifyAPI configures and sends HTTP requests through HTTParty, then review how request options are currently passed. Done means callers can provide proxy settings without changing HTTParty's global configuration, with coverage for the supported proxy behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
api, networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.