Shopify / Shopify/shopify-api-ruby

GraphQL throttling

Open
#1,345 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
1.1k
Forks
484
PR merge metrics
No merged PRs in 30d

Description

Overview/summary

It doesn't seem like the gem has built-in handling of throttling for GraphQL, as it does for REST.

With REST being somewhat deprecated, are there any plans to handle GraphQL throttling inside the gem, or do we have to inherit/extend from the client and implement a custom throttling solution around the query method?

This seems like a weird omission, because the REST throttling is taken care of, but I couldn't find anything for GraphQL.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the gem's existing REST throttling implementation and the GraphQL client query method mentioned in the issue. Compare their behavior and determine the expected GraphQL throttling scope; done requires an agreed approach and tests covering it.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, ruby
Domain
api, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.