Shopify / Shopify/shipit-engine

Support multiple ./packages-*/ directories

Open
#946 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
1.5k
Forks
154
Avg merge
2h 26m
Merged PRs (30d)
3

Description

This line: https://github.com/Shopify/shipit-engine/blob/740b8a98eb7c11f84378334270e320d986ce6b1a/lib/snippets/assert-lerna-independent-version-tags#L19

Fails deploys of polaris-icons for packages not in /packages/.

In this deployment:
https://shipit.shopify.io/shopify/polaris-icons/libraries-js/deploys/843212

The version in ./packages-ruby/polaris_icons/package.json isn't being detected correctly:

$ assert-lerna-independent-version-tags
pid: 362510
module.js:550
    throw err;
    ^
Error: Cannot find module './packages/polaris_icons/package.json'
    at Function.Module._resolveFilename (module.js:548:15)
    at Function.Module._load (module.js:475:25)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at [eval]:1:13
    at ContextifyScript.Script.runInThisContext (vm.js:50:33)
    at Object.runInThisContext (vm.js:139:38)
    at Object.<anonymous> ([eval]-wrapper:6:22)
    at Module._compile (module.js:653:30)
    at evalScript (bootstrap_node.js:479:27)
polaris_icons is tagged as 0.3.0, but its package.json version is .

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The relevant entry point is lib/snippets/assert-lerna-independent-version-tags, and the failure is reproduced by running assert-lerna-independent-version-tags against the polaris-icons layout. Trace how ./packages/.../package.json is selected, then verify that package.json files under packages-* are detected and their versions are compared with tags.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, ruby
Domain
devops, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.