Shopify / Shopify/shipit-engine

Automated flagging of rollback safety

Open
#879 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
1.5k
Forks
154
Avg merge
2h 26m
Merged PRs (30d)
3

Description

Many pull request templates, including Shopify core, have a "This is safe to rollback" checkbox. This helps people during incidents to assess the risk of rolling back vs fixing forward. With our larger deploy batch sizes, and separate deploy batches for canary and production, it is becoming very hard for a human to assess rollback safety. This has resulted in situations where people have decided to fix forward rather than rollback, which adds significant time to the impact of a disruption. As one example, this came up during RCA discussion for https://github.com/Shopify/service-disruptions/issues/1037.

Idea: explicitly model "safe to rollback" in Shipit rather than via PR template checkbox. Perhaps it is exposed via HCTW as an extra field next to "Add to Merge queue". Shipit can than quickly determine if a batch of changes is "unsafe to rollback" and indicate this in the Shipit UI. This would not be foolproof but it would help a human responder more quickly discover cases where rollback is not safe.

This would also help us collect a list of cases that are not safe that we can work towards eliminating, with the goal of eventually never shipping changes that are not "safe to rollback".

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the issue proposal and the linked service-disruptions RCA discussion, then trace how HCTW and the Shipit UI currently represent merge-queue changes and deployment batches. Done would require an agreed design for modeling rollback safety, surfacing unsafe batches, and collecting the resulting cases; the issue names no files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
devops, release
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.