Shopify / Shopify/shipit-engine
Commit locking system is confusing
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 154
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 3
Description
@byroot @qq99 @NatMorcos we discovered today that the commit locking system is rather confusing, because locking a single commit as bad doesn't prevent a deploy going out with that commit included. The simplest fix is likely:
when manually marking a commit as bad, all commits after it should be marked as bad until a second commit is manually marked as good
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the commit-locking flow for manually marking commits bad or good, then check how deploy eligibility handles commits after a bad one. Confirm the existing behavior and identify the relevant tests before defining completion as preventing deployment until a later commit is manually marked good.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- devops, release
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100