Shopify / Shopify/shipit-engine

Automate registry config in lerna deploy spec

Open
#846 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
1.5k
Forks
154
Avg merge
2h 26m
Merged PRs (30d)
3

Description

Our internal quilt stack has published:

  • Deploy 675247 - @shopify/network@1.0.1 (public)
  • Deploy 678756 - @shopify/network@1.0.2 (private), @shopify/react-network@1.0.0 (private)
  • Deploy 678772 - @shopify/react-network@1.0.1 (private)

Is it possible that the .npmrc for solo package publication is leaking into monorepo environments, @ismail-syed?

cc @nickjs, @lemonmade

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read app/models/shipit/deploy_spec/npm_discovery.rb around line 160 and compare how registry configuration is selected for solo packages versus monorepos. Trace the listed deployments if possible; done means confirming whether .npmrc leaks into monorepo publication and documenting the required behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.