Shopify / Shopify/shipit-engine

npm publish: should publishConfig.tag be satisfied?

Open
#843 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
1.5k
Forks
154
Avg merge
2h 26m
Merged PRs (30d)
3

Description

At the moment, shipit-engine infers the dist-tag from prerelease flags in the version's name:

https://github.com/Shopify/shipit-engine/blob/9052291a4aa9da5d37ff86d54549f21921596718/app/models/shipit/deploy_spec/npm_discovery.rb#L55-L62

Should this package.json config take precedence over this inference?

{
  "publishConfig": {
    "tag": "whatever"
  }
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in app/models/shipit/deploy_spec/npm_discovery.rb at lines 55-62, then review the issue discussion about package.json publishConfig.tag versus prerelease inference. Determine the intended precedence and identify the existing behavior that would need coverage; done means the decision is documented and the npm dist-tag behavior consistently follows it.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.