Shopify / Shopify/shipit-engine
[Lerna] Use ruby instead of a bash script for lerna package assertion
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 154
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 3
Description
It would be nice to be more consistent with these scripts. Ruby is probably a better choice for consistency and maintenance.
https://github.com/Shopify/shipit-engine/blob/fix/override-skip-npm-setting/lib/snippets/assert-lerna-independent-version-tags#L5
https://github.com/Shopify/shipit-engine/blob/fix/override-skip-npm-setting/lib/snippets/assert-lerna-fixed-version-tag#L20
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading lib/snippets/assert-lerna-independent-version-tags and lib/snippets/assert-lerna-fixed-version-tag, especially the referenced script sections. Replace the bash-based assertions with Ruby while preserving their existing package-version checks; done means both snippets remain functionally equivalent and consistent with the other scripts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- bash, ruby
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100