Shopify / Shopify/shipit-engine

[Lerna] parse lerna.json instead of making assumptions

Open
#769 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Ruby
Stars
1.5k
Forks
154
Avg merge
2h 26m
Merged PRs (30d)
3

Description

We should parse lerna.json to find the correct directories for packages rather than assuming it will always be /packages.

ex. https://github.com/Shopify/shipit-engine/blob/master/lib/snippets/assert-lerna-independent-version-tags#L19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/snippets/assert-lerna-independent-version-tags, referenced in the issue, and inspect how it currently determines package directories. Read the repository's handling of lerna.json and identify the relevant tests or test entry point. Done means package directories come from lerna.json rather than assuming /packages.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.