Shopify / Shopify/shipit-engine

Convert to Bootstrap 4

Open
#567 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Design
Dominant language
Ruby
Stars
1.5k
Forks
154
Avg merge
2h 26m
Merged PRs (30d)
3

Description

These are all the pages (not including the partials) that will need to be converted to Bootstrap. Each page is broken down into 3 sections html/css, js, and tests. Since the selectors will most likely change, theres a good chance that the tests will need updated. Similarly the js will need to work with the new DOM.

  • missing settings
    • html / css
    • js
    • tests
  • deploys new
    • html / css
    • js
    • tests
  • deploys rollback
    • html / css
    • js
    • tests
  • deploys show
    • html / css
    • js
    • tests
  • github auth failed
    • html / css
    • js
    • tests
  • stacks index
    • html / css
    • js
    • tests
  • stacks new
    • html / css
    • js
    • tests
  • stacks settings
    • html / css
    • js
    • tests
  • stacks show
    • html / css
    • js
    • tests
  • tasks index
    • html / css
    • js
    • tests
  • tasks new
    • html / css
    • js
    • tests
  • tasks show
    • html / css
    • js
    • tests
  • application layout
    • html / css
    • js
    • tests

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the unchecked page list: missing settings, deploys, GitHub auth failed, stacks, tasks, and the application layout. For each page, inspect its html/css, js, and tests sections, using the completed stacks new conversion as a reference. Done means every listed subsection is converted to Bootstrap 4 and its tests work with the updated DOM.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, css, javascript
Domain
frontend, testing
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.