Shopify / Shopify/shipit-engine
Pubsubstub improvment
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 154
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 3
Description
Currently Pubsubstub cause a bunch of minor but annoying issues.
- Any other server than thin will run it in "degraded" mode
- Even with thin, you have to force reload (closing open connections), otherwise SSE connections will never timeout
I discussed this a bit with @gmalette, and we think it would be valuable to be able to run it in an external process. That way force reloading it is not an issue.
The default would still be to run it inline though.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Pubsubstub and its current Thin/server and SSE integration. Determine how an external process can be selected while preserving inline execution as the default, then verify that force reloads are unnecessary and SSE connections still time out correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend, devops
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100